[RFC PATCH xlnx] net: xilinx: axienet_ethtools_sset_count() can be static

kernel test robot lkp at intel.com
Wed Jun 23 12:44:44 PDT 2021


drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: warning: symbol 'axienet_ethtools_sset_count' was not declared. Should it be static?
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2673:6: warning: symbol 'axienet_ethtools_get_stats' was not declared. Should it be static?
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2700:6: warning: symbol 'axienet_ethtools_strings' was not declared. Should it be static?

Fixes: 0605a36e0574 ("net: xilinx: Ethtool statistics support")
Reported-by: kernel test robot <lkp at intel.com>
Signed-off-by: kernel test robot <lkp at intel.com>
---
 xilinx_axienet_main.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 3911718d5618b..e56ccdb41867d 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -2647,7 +2647,7 @@ static int axienet_ethtools_get_ts_info(struct net_device *ndev,
  * Return: number of strings, on success, Non-zero error value on
  *	   failure.
  */
-int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
+static int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
 {
 	switch (sset) {
 	case ETH_SS_STATS:
@@ -2670,9 +2670,9 @@ int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
  *
  * Return: None.
  */
-void axienet_ethtools_get_stats(struct net_device *ndev,
-				struct ethtool_stats *stats,
-				u64 *data)
+static void axienet_ethtools_get_stats(struct net_device *ndev,
+				       struct ethtool_stats *stats,
+				       u64 *data)
 {
 	unsigned int i = 0;
 
@@ -2697,7 +2697,7 @@ void axienet_ethtools_get_stats(struct net_device *ndev,
  *
  * Return: None.
  */
-void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
+static void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
 {
 	int i;
 



More information about the linux-arm-kernel mailing list