[PATCH] drivers/firmware/psci: Fix application of sizeof to pointer

Jason Wang wangborong at cdjrlc.com
Fri Jun 11 05:00:09 PDT 2021


The 2nd parameter of kcalloc should be the element size, that is
the type size of '*cpu_groups' not the pointer size of 'cpu_groups'.

Signed-off-by: Jason Wang <wangborong at cdjrlc.com>
---
 drivers/firmware/psci/psci_checker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c
index 9a369a2eda71..116eb465cdb4 100644
--- a/drivers/firmware/psci/psci_checker.c
+++ b/drivers/firmware/psci/psci_checker.c
@@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
 	if (!alloc_cpumask_var(&tmp, GFP_KERNEL))
 		return -ENOMEM;
 
-	cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups),
+	cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups),
 			     GFP_KERNEL);
 	if (!cpu_groups) {
 		free_cpumask_var(tmp);
-- 
2.31.1






More information about the linux-arm-kernel mailing list