[PATCH v3] ARM: imx: add smp support for imx7d

Fabio Estevam festevam at denx.de
Sat Jun 5 07:35:36 PDT 2021


Hi Shawn,

On 25/05/2021 21:14, Fabio Estevam wrote:
> From: Anson Huang <b20788 at freescale.com>
> 
> Add SMP support for i.MX7D, including CPU hotplug support, for
> systems where TFA is not present.
> 
> The motivation for bringing up the second i.MX7D core inside the kernel
> is that legacy vendor bootloaders usually do not implement PSCI 
> support.
> 
> This is a significant blocker for systems in the field that are running 
> old
> bootloader versions to upgrade to a modern mainline kernel version, as 
> only
> one CPU of the i.MX7D would be brought up.
> 
> Bring up the second i.MX7D core inside the kernel to make the migration
> path to mainline kernel easier for the existing iMX7D users.
> 
> Signed-off-by: Anson Huang <b20788 at freescale.com>
> Signed-off-by: Arulpandiyan Vadivel <arulpandiyan_vadivel at mentor.com>
> # Fix merge conflicts
> Signed-off-by: Leonard Crestez <leonard.crestez at nxp.com>
> Signed-off-by: Marek Vasut <marex at denx.de> # heavy cleanup
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---
> Changes since v2:
> - Removed the DT comment part from the commit log - Shawn
> - Added comments in the code explaining the motivation of bringing
> up the second core inside the kernel - Shawn
> - Fixed checkpatch warnings, except the one regarding NR_CPUS,
> which Russell King explained that the current usage is correct - Shawn
> - Made imx_gpcv2_set_m_core_pgc() static - Shawn
> - Read PDN/PUP register after imx_gpcv2_set_m_core_pgc() - Shawn
> - Removed WARN_ON() occurrences - Shawn
> - Added comments in the commit log explaining the motivation of 
> bringing
> up the second core inside the kernel.

I tried to address all your previous comments about this patch.

Do you think this version is OK? Could it land in 5.14?

Thanks,

Fabio Estevam



More information about the linux-arm-kernel mailing list