[PATCH v3 08/20] arm64: entry: organise entry handlers consistently

[Will Deacon]

On Fri, Jun 04, 2021 at 06:39:59PM +0100, Mark Rutland wrote:
> On Fri, Jun 04, 2021 at 05:51:41PM +0100, Will Deacon wrote:
> > On Tue, May 25, 2021 at 07:32:50PM +0100, Mark Rutland wrote:
> > > In entry.S we have two comments which distinguish EL0 and EL1 exception
> > > handlers, but the code isn't actually laid out this way, and there are a
> > > few other inconsitencies that would be good to clear up.
> > 
> > Typo: inconsitencies
> > 
> > > This patch organizes the entry handers consistently:
> > > 
> > > * The handlers are laid out in order of the vectors, to make them easier
> > >   to navigate.
> > > 
> > > * All handlers are given the same alignment, which was previously
> > >   applied inconsitently.
> > 
> > It's that word again.
> > 
> > Anyway, why is this alignment needed in the first place?
> 
> The alignemnt isn't functionally necessary. It's been there since day 1,
> in commit:
> 
>   60ffc30d5652810d ("arm64: Exception handling")
> 
> I'm happy to have them or delete them; I just need to make this
> consistent for when this gets templated.

I agree that consistency is good here, so the "obvious" thing would be
to use SYM_CODE_START_LOCAL because we don't have any specific alignment
constraints, I think.

Will