[PATCH -next] firmware: arm_scmi: Fix the build when CONFIG_MAILBOX is not selected
Cristian Marussi
cristian.marussi at arm.com
Thu Jun 3 05:55:02 PDT 2021
Reviewed-by: Cristian Marussi <cristian.marussi at arm.com>
Tested-by: Cristian Marussi <cristian.marussi at arm.com>
Cristian
On Thu, Jun 03, 2021 at 08:26:31AM +0100, Sudeep Holla wrote:
> 0day CI kernel test robot reported following build error with randconfig
>
> aarch64-linux-ld: drivers/firmware/arm_scmi/driver.o:(.rodata+0x1e0):
> undefined reference to `scmi_mailbox_desc'
>
> Fix the error by adding CONFIG_MAILBOX dependency for scmi_mailbox_desc.
>
> Cc: Etienne Carriere <etienne.carriere at linaro.org>
> Cc: Cristian Marussi <cristian.marussi at arm.com>
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index 5e8e9337adc7..ca71568c5c41 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -1571,7 +1571,9 @@ ATTRIBUTE_GROUPS(versions);
>
> /* Each compatible listed below must have descriptor associated with it */
> static const struct of_device_id scmi_of_match[] = {
> +#ifdef CONFIG_MAILBOX
> { .compatible = "arm,scmi", .data = &scmi_mailbox_desc },
> +#endif
> #ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY
> { .compatible = "arm,scmi-smc", .data = &scmi_smc_desc},
> #endif
> --
> 2.25.1
>
More information about the linux-arm-kernel
mailing list