[PATCH 1/2] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag

Mark Rutland mark.rutland at arm.com
Wed Jun 2 03:14:13 PDT 2021


On Wed, Jun 02, 2021 at 09:00:41AM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
> 
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
> 
> Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>

I see that the patch above was merged in v5.13-rc1 as commit:

  cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")

With that in mind:

Acked-by: Mark Rutland <mark.rutland at arm.com>

... I expect Will will pick this up.

Thanks,
Mark.

> ---
>  drivers/perf/arm_pmu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index e57b348..eb3a802 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
>  		}
>  
>  		irq_flags = IRQF_PERCPU |
> -			    IRQF_NOBALANCING |
> +			    IRQF_NOBALANCING | IRQF_NO_AUTOEN |
>  			    IRQF_NO_THREAD;
>  
> -		irq_set_status_flags(irq, IRQ_NOAUTOEN);
> -
>  		err = request_nmi(irq, handler, irq_flags, "arm-pmu",
>  				  per_cpu_ptr(&cpu_armpmu, cpu));
>  
> -- 
> 2.7.4
> 



More information about the linux-arm-kernel mailing list