[PATCH v2 07/12] memory: tegra: Parameterize interrupt handler

[Thierry Reding]

On Tue, Jun 01, 2021 at 10:37:19PM +0300, Dmitry Osipenko wrote:
> 01.06.2021 21:53, Dmitry Osipenko пишет:
> > 01.06.2021 20:59, Thierry Reding пишет:
> >> --- a/drivers/memory/tegra/mc.h
> >> +++ b/drivers/memory/tegra/mc.h
> >> @@ -135,9 +135,13 @@ extern const struct tegra_mc_soc tegra210_mc_soc;
> >>      defined(CONFIG_ARCH_TEGRA_132_SOC) || \
> >>      defined(CONFIG_ARCH_TEGRA_210_SOC)
> >>  int tegra30_mc_probe(struct tegra_mc *mc);
> >> +irqreturn_t tegra30_mc_handle_irq(int irq, void *data);
> > 
> > tegra30_mc_handle_irq() doesn't need to be made global, it's defined and
> > used only within mc.h.
> > 
> 
> You could make this function static and annotate it with maybe_unused.

This doesn't even need to be __maybe_unused because it's declared in the
same #if/#endif block as tegra30_mc_ops. But yeah, I can make this
static to mc.c. Initially I had thought that this was going to be used
by tegra186_mc_ops as well, but we can always export it if necessary
when that work materializes.

Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20210602/3c7881cf/attachment-0001.sig>