[PATCH 1/4] drivers: phy: add support for Armada CP110 UTMI PHY

Lubomir Rintel lkundrak at v3.sk
Fri Jan 29 13:22:19 EST 2021


On Fri, Jan 29, 2021 at 10:07:13AM +0000, Russell King - ARM Linux admin wrote:
> On Fri, Jan 29, 2021 at 10:28:49AM +0100, Lubomir Rintel wrote:
> > > +	/*
> > > +	 * Setup PLL. 40MHz clock used to be the default, being 25MHz now.
> > > +	 * See the functional specification for details.
> > 
> > I tried to, couldn't find it. Perhaps you could elaborate more here, or
> > include a link in the header.
> 
> Marvell documents are generally not publically available. This is the
> case here.

In that case the "elaborate more" part applies, otherwise the comment
remains rather meaningless. Perhaps it wouldn't be too difficult to
clarify things with an extra sentence or two without revealing any
secrets.

> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Take care
Lubo



More information about the linux-arm-kernel mailing list