[PATCH v3 1/2] arm64: Improve kernel address detection of __is_lm_address()

Catalin Marinas catalin.marinas at arm.com
Fri Jan 22 09:49:58 EST 2021


On Fri, Jan 22, 2021 at 02:37:47PM +0000, Vincenzo Frascino wrote:
> Currently, the __is_lm_address() check just masks out the top 12 bits
> of the address, but if they are 0, it still yields a true result.
> This has as a side effect that virt_addr_valid() returns true even for
> invalid virtual addresses (e.g. 0x0).
> 
> Improve the detection checking that it's actually a kernel address
> starting at PAGE_OFFSET.
> 
> Cc: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Will Deacon <will at kernel.org>
> Suggested-by: Catalin Marinas <catalin.marinas at arm.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino at arm.com>

Reviewed-by: Catalin Marinas <catalin.marinas at arm.com>

The question is whether we leave this for 5.12 or we merge it earlier.

-- 
Catalin



More information about the linux-arm-kernel mailing list