[PATCH v3 02/21] mmc: sunxi: add support for A100 mmc controller

[Maxime Ripard]

Hi Andre,

On Mon, Jan 18, 2021 at 03:52:28PM +0000, Andre Przywara wrote:
> On Mon, 18 Jan 2021 14:28:54 +0100
> Maxime Ripard <maxime at cerno.tech> wrote:
> 
> Hi Maxime,
> 
> > On Mon, Jan 18, 2021 at 02:08:29AM +0000, Andre Przywara wrote:
> > > From: Yangtao Li <frank at allwinnertech.com>
> > > 
> > > This patch adds support for A100 MMC controller, which use word
> > > address for internal dma.
> > > 
> > > Signed-off-by: Yangtao Li <frank at allwinnertech.com>
> > > Signed-off-by: Andre Przywara <andre.przywara at arm.com>  
> > 
> > We should also disable the timings setup in probe to derive them from
> > the DT. This is causing issues on some SoCs already, so it would be
> > best to not make the situation worse
> 
> But only for those new SoCs, where we have the speed modes in the DT
> in every case (so only new ones)? And this disabling would be
> SoC/compatible string dependent? Happy to send a patch later if that is
> what you were thinking about.

Yeah, we should only do it for new SoCs at the moment, based on the
compatible.

I guess at some point we'll have to remove it for the older SoCs as well
since we have reports of it failing for SoCs as old as the A20, but
we'll probably want to make it as smooth as possible.

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20210121/ac59766c/attachment.sig>