[PATCH 1/2] soc: imx: gpc: Remove unused .id_table

Lucas Stach l.stach at pengutronix.de
Mon Jan 18 07:56:33 EST 2021


Hi Fabio,

Am Montag, dem 18.01.2021 um 09:03 -0300 schrieb Fabio Estevam:
> i.MX has been converted to a dt-only platform.
> 
> Remove the unused .id_table.

Did you test this commit? I believe it is wrong and should not be
applied. The power domains don't have a compatible in the DT, so the
driver for the individual domains is in fact probed via the platform id
table.

Regards,
Lucas

> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
>  drivers/soc/imx/gpc.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 90a8b2c0676f..06f15ca6c9ed 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -224,18 +224,12 @@ static int imx_pgc_power_domain_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> 
> 
> 
> -static const struct platform_device_id imx_pgc_power_domain_id[] = {
> -	{ "imx-pgc-power-domain"},
> -	{ },
> -};
> -
>  static struct platform_driver imx_pgc_power_domain_driver = {
>  	.driver = {
>  		.name = "imx-pgc-pd",
>  	},
>  	.probe = imx_pgc_power_domain_probe,
>  	.remove = imx_pgc_power_domain_remove,
> -	.id_table = imx_pgc_power_domain_id,
>  };
>  builtin_platform_driver(imx_pgc_power_domain_driver)
>  
> 
> 
> 





More information about the linux-arm-kernel mailing list