[PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p

[Doug Anderson]

Hi,

On Fri, Jan 15, 2021 at 6:58 AM Benjamin Tissoires
<benjamin.tissoires at redhat.com> wrote:
>
> > Thanks, but don't spend too much time on it, unless something really
> > jumps out. I'll debug that tomorrow. It's much easier with an actual
> > device than by just looking at the code.
> >
>
> Well, that's weird. Now suspend resume works reliably even with your
> series. It could just have been that the lid sensor was too close to a
> magnet or something like that. Though while testing the old version of
> i2c-hid, it was working... Such a mystery :)

Friggin magnets, how do those work?  ;-)

I also managed to obtain remote access to a device with an ACPI
i2c-hid device and confirmed that suspend/resume was working and that
I saw no errors, though obviously I couldn't physically interact with
the device remotely.  Hopefully that gives a tiny bit of extra
confidence that the series is OK...


> This allows to keep the powering ordering of the old i2c-hid module
> (power up before setting device wakeup capable), and simplify the
> not so obvious power_fixed field of struct i2c_hid_acpi.
>
> (I can also send it as a followup on the series if you prefer).

Squashed it into a v9 as well as a local variable rename that I
noticed while looking at the code with fresh eyes.  My v9 also
incorporates the new Goodix timing that I self-commented about on v8.

Crossing fingers that it's all good now.  :-)

-Doug