[PATCH 1/1] ARM: imx: build suspend-imx6.S with arm instruction set

Oleksandr Suvorov cryosay at gmail.com
Mon Jan 11 12:38:15 EST 2021


On Mon, Jan 11, 2021 at 5:20 PM Max Krummenacher <max.oss.09 at gmail.com> wrote:
>
> When the kernel is configured to use the Thumb-2 instruction set
> "suspend-to-memory" fails to resume. Observed on a Colibri iMX6ULL
> (i.MX 6ULL) and Apalis iMX6 (i.MX 6Q).
>
> It looks like the CPU resumes unconditionally in ARM instruction mode
> and then chokes on the presented Thumb-2 code it should execute.
>
> Fix this by using the arm instruction set for all code in
> suspend-imx6.S.
>
> Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
Acked-by: Oleksandr Suvorov <oleksandr.suvorov at toradex.com>
>
> ---
>
>  arch/arm/mach-imx/suspend-imx6.S | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-imx/suspend-imx6.S b/arch/arm/mach-imx/suspend-imx6.S
> index 1eabf2d2834be..e06f946b75b96 100644
> --- a/arch/arm/mach-imx/suspend-imx6.S
> +++ b/arch/arm/mach-imx/suspend-imx6.S
> @@ -67,6 +67,7 @@
>  #define MX6Q_CCM_CCR   0x0
>
>         .align 3
> +       .arm
>
>         .macro  sync_l2_cache
>
> --
> 2.26.2
>


-- 
Best regards

Oleksandr Suvorov
cryosay at gmail.com



More information about the linux-arm-kernel mailing list