[PATCH v1 16/17] arm64: dts: sdm845-db845c: Add CAMSS ISP node

[Laurent Pinchart]

Hi Rob,

Thank you for the patch.

The subject line doesn't match the patch.

On Fri, Jan 08, 2021 at 01:04:28PM +0100, Robert Foss wrote:
> Add regulators and camss DT node.
> 
> Signed-off-by: Robert Foss <robert.foss at linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index a943b3f353ce..7bad0515345e 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -294,6 +294,9 @@ vreg_s7a_1p025: smps7 {
>  			regulator-max-microvolt = <1028000>;
>  		};
>  
> +		vdda_mipi_csi0_0p9:
> +		vdda_mipi_csi1_0p9:
> +		vdda_mipi_csi2_0p9:

No need for new labels, you can simply use vreg_l1a_0p875 below.

>  		vreg_l1a_0p875: ldo1 {
>  			regulator-min-microvolt = <880000>;
>  			regulator-max-microvolt = <880000>;
> @@ -1106,6 +1109,15 @@ &cci {
>  	status = "okay";
>  };
>  
> +&camss {
> +	vdda-csi0-supply = <&vdda_mipi_csi0_0p9>;
> +	vdda-csi1-supply = <&vdda_mipi_csi1_0p9>;
> +	vdda-csi2-supply = <&vdda_mipi_csi2_0p9>;
> +
> +	status = "disabled";

This isn't needed.

> +

Extra blank line.

> +};
> +
>  &cci_i2c0 {
>  	camera at 10 {
>  		compatible = "ovti,ov8856";

-- 
Regards,

Laurent Pinchart