[PATCH v2 3/3] staging: vc04_services: Add a note to the TODO

Phil Elwell phil at raspberrypi.com
Tue Jan 5 11:20:30 EST 2021


Record in the TODO file that the address of "&waiter->bulk_waiter"
should never be returned to userspace.

Signed-off-by: Phil Elwell <phil at raspberrypi.com>
---
 drivers/staging/vc04_services/interface/TODO | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
index fc2752bc95b2..0bcb8f158afc 100644
--- a/drivers/staging/vc04_services/interface/TODO
+++ b/drivers/staging/vc04_services/interface/TODO
@@ -91,3 +91,7 @@ The first thing one generally sees in a probe function is a memory allocation
 for all the device specific data. This structure is then passed all over the
 driver. This is good practice since it makes the driver work regardless of the
 number of devices probed.
+
+14) Clean up Sparse warnings from __user annotations. See
+vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter"
+is never disclosed to userspace.
-- 
2.25.1




More information about the linux-arm-kernel mailing list