[PATCH net 1/4] net: stmmac: dwmac-sun8i: Fix probe error handling

[Chen-Yu Tsai]

On Sun, Jan 3, 2021 at 7:17 PM Samuel Holland <samuel at sholland.org> wrote:
>
> stmmac_pltfr_remove does three things in one function, making it
> inapproprate for unwinding the steps in the probe function. Currently,
> a failure before the call to stmmac_dvr_probe would leak OF node
> references due to missing a call to stmmac_remove_config_dt. And an
> error in stmmac_dvr_probe would cause the driver to attempt to remove a
> netdevice that was never added. Fix these by reordering the init and
> splitting out the error handling steps.
>
> Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
> Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path")
> Signed-off-by: Samuel Holland <samuel at sholland.org>

Reviewed-by: Chen-Yu Tsai <wens at csie.org>