[PATCH 5/6] gpiolib: Fix return check of __irq_domain_alloc_irqs

Adam Lackorzynski adam at l4re.org
Sat Jan 2 12:58:58 EST 2021


0 is not a proper IRQ number and also indicates failure.

Signed-off-by: Adam Lackorzynski <adam at l4re.org>
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index b02cc2abd3b6..9667e1a62626 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1003,7 +1003,7 @@ static void gpiochip_set_hierarchical_irqchip(struct gpio_chip *gc,
 						      &fwspec,
 						      false,
 						      NULL);
-			if (ret < 0) {
+			if (ret <= 0) {
 				chip_err(gc,
 					 "can not allocate irq for GPIO line %d parent hwirq %d in hierarchy domain: %d\n",
 					 i, parent_hwirq,
-- 
2.30.0.rc2




More information about the linux-arm-kernel mailing list