[PATCH v2] media: exynos4-is: add missing call to of_node_put()

Krzysztof Kozlowski krzk at kernel.org
Fri Feb 26 05:29:23 EST 2021


On Fri, 26 Feb 2021 at 02:28, Yang Li <yang.lee at linux.alibaba.com> wrote:
>
> In one of the error paths of the for_each_child_of_node() loop in
> fimc_md_parse_one_endpoint, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
> Function "for_each_child_of_node" should have of_node_put() before
> return around line 492.
>
> Reported-by: Abaci Robot <abaci at linux.alibaba.com>

You ignored the comment for this. Anyone can run Coccinelle and it
does not equal "Reported-by" credit. Reported by is for reported bugs,
but I asked three times to you guys to share the reports. This is not
an open way of working.

This should be removed.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list