[PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
sboyd at kernel.org
Fri Feb 12 17:05:45 EST 2021
Quoting Lee Jones (2021-02-12 13:26:30)
> On Fri, 12 Feb 2021, Lee Jones wrote:
> > The alternative is to not worry about it and review the slow drip of
> > fixes that will occur as a result. The issues I just fixed were built
> > up over years. They won't get to that level again.
> > In my mind contributors should be compiling their submissions with W=1
> > enabled by default. I'm fairly sure the auto-builders do this now.
> > Once W=1 warnings are down to an acceptable level in the kernel as a
> > whole, we can provide some guidance in SubmittingPatches (or similar)
> > on how to enable them (hint: you add "W=1" on the compile line).
> > Enabling W=1 in the default build will only serve to annoy Linus IMHO.
> > If he wants them to be enabled by default, they wouldn't be W=1 in the
> > first place, they'd be W=0 which *is* the default build.
> Just to add real quick - my advice is to enable them for yourself and
> send back any issues along with your normal review. A W=1 issue is no
> different to a semantic or coding style one.
I'd like to enable it for only files under drivers/clk/ but it doesn't
seem to work. I'm not asking to enable it at the toplevel Makefile. I'm
asking to enable it for drivers/clk/ so nobody has to think about it now
that you've done the hard work of getting the numbers in this directory
down to zero or close to zero.
More information about the linux-arm-kernel