[PATCH v2 2/8] drivers/perf: hisi: Add PMU version for uncore PMU drivers.

Mark Rutland mark.rutland at arm.com
Wed Feb 3 07:58:18 EST 2021


On Wed, Feb 03, 2021 at 03:51:02PM +0800, Shaokun Zhang wrote:
> For HiSilicon uncore PMU, more versions are supported and some variables
> shall be added suffix to distinguish the version which are prepared for
> the new drivers.
> 
> Cc: Mark Rutland <mark.rutland at arm.com>
> Cc: Will Deacon <will at kernel.org>
> Cc: John Garry <john.garry at huawei.com>
> Cc: Jonathan Cameron <Jonathan.Cameron at huawei.com>
> Reviewed-by: John Garry <john.garry at huawei.com>
> Co-developed-by: Qi Liu <liuqi115 at huawei.com>
> Signed-off-by: Qi Liu <liuqi115 at huawei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun at hisilicon.com>
> ---
>  drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 97 ++++++++++++++-------------
>  drivers/perf/hisilicon/hisi_uncore_hha_pmu.c  | 27 ++++----
>  drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c  | 24 +++----
>  3 files changed, 75 insertions(+), 73 deletions(-)

[...]

> diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> index 831622e0c445..da56fa16b97e 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
> @@ -37,7 +37,7 @@
>  
>  #define L3C_PERF_CTRL_EN	0x10000
>  #define L3C_EVTYPE_NONE		0xff
> -
> +#define L3C_V1_NR_EVENTS	0x59
>  /*
>   * Select the counter register offset using the counter index
>   */

I don't think you meant to remove the line space before the comment here.

With that restored:

Acked-by: Mark Rutland <mark.rutland at arm.com>

Mark.



More information about the linux-arm-kernel mailing list