[PATCH] arm64: Fix early pointer print plus improve comment

Guilherme G. Piccoli gpiccoli at igalia.com
Tue Dec 21 06:43:40 PST 2021


On 21/12/2021 07:11, Robin Murphy wrote:
> [...]
> %pa is the correct specifier for printing a physical address, so I don't 
> really follow what's being "fixed" here. Especially given that what this 
> will now do is print the virtual address of the local dt_phys variable 
> itself. How is that useful?

Hi Robin, thanks a lot for your review, and I owe you (and the list) an
apology. I confused myself, this is not the one to fix - the %p on
virtual address is the one that is bogus!

This patch (the doc part) was stuck here for some months..and I
remembered that there was a pointer hashed that I also fixed to see its
value (in an issue I was investigating that time), but I swapped the
pointers! My bad, it was a lame confusion.

I'll submit a V2! Just for the sake of completeness, I've tested and
having the virt address with %p got me a "0x(____ptrval____)", while
with %px I can see "0xfffffbfffdc00000)".

Cheers,


Guilherme



More information about the linux-arm-kernel mailing list