[PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support

Marc Zyngier maz at kernel.org
Wed Dec 8 06:22:25 PST 2021


Hi Alexandre,

On Wed, 08 Dec 2021 13:58:46 +0000,
Alexandre TORGUE <alexandre.torgue at foss.st.com> wrote:
> 
> > Why does the driver need to carry these tables? This sort of
> > information should really come from DT, instead of being hardcoded in
> > the driver and bloating it for no reason. This all has a funny taste
> > of the board files we used to have pre-DT.
> > 
> 
> There are absolutely no reason to have it in driver. Honestly It has
> been done in this way to have minimal changes adding this new SoC
> support (and it's not smart, I agree).
> 
> I think it is better to abandon this series. I will create a new one
> which moves mapping table for MP15 and adds MP13 support to.

I'm afraid you'll have to keep the in-kernel table for MP15, since the
driver needs to work with old DTs. For new SoCs (such as MP13), moving
the table into DT would be good.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list