[PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit.

Nicolas Saenz Julienne nsaenzju at redhat.com
Fri Apr 23 18:34:14 BST 2021


On Fri, 2021-04-23 at 17:20 +0100, Mark Brown wrote:
> On Fri, Apr 23, 2021 at 03:12:11PM +0100, Joe Burmeister wrote:
> > Of course we could just raise BCM2835_SPI_NUM_CS to 8 or more if that is
> > preferred. Does seams like the dynamic solution is less favoured.
> 
> The best thing would be to have it not have a single array of chip
> select specific data and instead store everything in the controller_data
> that's there per-device.

+1

All in all, it would make for a cleaner driver.

-- 
Nicolás Sáenz




More information about the linux-arm-kernel mailing list