[PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok

Edmundo Carmona Antoranz eantoranz at gmail.com
Sat Apr 10 20:58:22 BST 2021


On Sat, Apr 10, 2021 at 1:03 PM Marc Zyngier <maz at kernel.org> wrote:
>
> Hi Edmundo,

Sup!

>
>
> No difference? Have you simply tried removing the macro and witness
> the effect? If it made no difference, why have the macro at all then?

Oh, come on! so having the macro defined so that you can do things like

lib/vdso/gettimeofday.c:34:#ifndef vdso_clocksource_ok

counts as "a difference" to you? XD ok ok ... so, I have deleted
"extended linux kernel C preprocessor knowledge" from my linkedin
profile.

I can safely assume that this is a big resounding NACK, right? :-D

>
> Also, run this, for example:
>
> git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }'
>
> Are you going to "fix" these too?
>
> Thanks,

Thank you for the lesson, man. Still have a lot of stuff to learn in
front of me.

Pura vida!



More information about the linux-arm-kernel mailing list