[PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__

Andy Shevchenko andy.shevchenko at gmail.com
Thu Apr 1 10:24:50 BST 2021


On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan
<dmugil2000 at gmail.com> wrote:
>
> Change function's name to %s and __func__ to fix checkpatch.pl errors.

No, just drop the __func__ completely. First of all, we have a device
name, and uniqueness of the messages in the driver should guarantee
easy findings. Second, specific to _dbg() variants, with enabled
Dynamic Debug it can be chosen at run time!

I recommend going through all drivers and drop __func__ near to
dev_dbg() and pr_debug().

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list