[PATCH] clk: clk-prima2: fix return value check in prima2_clk_init()

Barry Song baohua at kernel.org
Fri Sep 25 22:50:32 EDT 2020


Xu Wang <vulab at iscas.ac.cn> 于2020年9月21日周一 下午3:45写道:
>
> In case of error, the function clk_register() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Xu Wang <vulab at iscas.ac.cn>


Acked-by: Barry Song <baohua at kernel.org>

Thanks

> ---
>  drivers/clk/sirf/clk-prima2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sirf/clk-prima2.c b/drivers/clk/sirf/clk-prima2.c
> index 45dcbc9e0302..d17b345f4d2d 100644
> --- a/drivers/clk/sirf/clk-prima2.c
> +++ b/drivers/clk/sirf/clk-prima2.c
> @@ -134,7 +134,7 @@ static void __init prima2_clk_init(struct device_node *np)
>
>         for (i = pll1; i < maxclk; i++) {
>                 prima2_clks[i] = clk_register(NULL, prima2_clk_hw_array[i]);
> -               BUG_ON(!prima2_clks[i]);
> +               BUG_ON(IS_ERR(prima2_clks[i]));
>         }
>         clk_register_clkdev(prima2_clks[cpu], NULL, "cpu");
>         clk_register_clkdev(prima2_clks[io],  NULL, "io");
> --
> 2.17.1
>



More information about the linux-arm-kernel mailing list