[PATCH v4 3/8] arm64/fpsimdmacros: Allow the macro "for" to be used in more cases

[Dave Martin]

On Tue, Sep 22, 2020 at 02:59:56PM +0100, Mark Brown wrote:
> On Tue, Sep 22, 2020 at 02:51:41PM +0100, Dave Martin wrote:
> > On Mon, Sep 21, 2020 at 07:09:10PM +0100, Mark Brown wrote:
> 
> > > Yes, this was my understanding of what this was doing when I looked
> > > through things when taking over the code - if we're going to use a
> > > different macro mode to the rest of the code then it seems sensible to
> > > make sure we don't try to build any other code with that macro mode
> > > otherwise it'll doubtless blow up in our faces at some point.
> 
> > I think that it's unlikely ever to be used except for this kind of
> > purpose, since it doesn't offer much over normal macro mode.
> 
> > altmacro mode is off by default, and can't be turned on via command-line
> > options IIRC, so it seems unlikely to be turned on everywhere by
> > accident.
> 
> Right, the issue is that if altmacro mode expansions pull in something
> that misbehaves when interpreted using altmacro mode that'd cause
> trouble so usages like this should take care to ensure that only code
> specifically writen for altmacro mode gets interpreted using it.

Agreed -- which is what this code is actually doing IIUC.

Cheers
---Dave