[PATCH v2 01/10] ARM: p2v: fix handling of LPAE translation in BE mode

[Linus Walleij]

On Mon, Sep 21, 2020 at 5:41 PM Ard Biesheuvel <ardb at kernel.org> wrote:

> When running in BE mode on LPAE hardware with a PA-to-VA translation
> that exceeds 4 GB, we patch bits 39:32 of the offset into the wrong
> byte of the opcode. So fix that, by rotating the offset in r0 to the
> right by 8 bits, which will put the 8-bit immediate in bits 31:24.
>
> Note that this will also move bit #22 in its correct place when
> applying the rotation to the constant #0x400000.
>
> Signed-off-by: Ard Biesheuvel <ardb at kernel.org>

That's a good catch!
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij