[PATCH 09/13] ARM: imx: Remove unused IO_ADDRESS() macros

Fabio Estevam festevam at gmail.com
Wed Sep 16 17:56:08 EDT 2020


Hi Arnd,

On Wed, Sep 16, 2020 at 6:35 PM Arnd Bergmann <arnd at arndb.de> wrote:

> As far as I can tell, the MX27_IO_P2V() macro should be removed here as
> well if MX27_IO_ADDRESS() gets removed.

The MX27_IO_P2V() macro is still used. Here is the error when I try to
remove it:

In file included from arch/arm/mach-imx/mach-imx27.c:17:0:
arch/arm/mach-imx/mach-imx27.c:30:16: error: implicit declaration of
function ‘MX27_IO_P2V’; did you mean ‘MX35_IO_P2V’?
[-Werror=implicit-function-declaration]
  imx_map_entry(MX27, AIPI, MT_DEVICE),
                ^
arch/arm/mach-imx/hardware.h:103:13: note: in definition of macro
‘imx_map_entry’
  .virtual = soc ## _IO_P2V(soc ## _ ## name ## _BASE_ADDR), \
             ^~~
arch/arm/mach-imx/mach-imx27.c:30:16: error: initializer element is not constant
  imx_map_entry(MX27, AIPI, MT_DEVICE),

> What about the other constants in these files? Are there any remaining
> references to the MX*_BASE_ADDRESS, MX*_INT_*, and MX*_DMA_REQ_*
> constants after the series?

Some of these can go away. I will remove what is possible in v2.



More information about the linux-arm-kernel mailing list