[PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

Chun-Kuang Hu chunkuang.hu at kernel.org
Mon Sep 14 19:37:30 EDT 2020


Hi, Yu Kuai:

Yu Kuai <yukuai3 at huawei.com> 於 2020年9月5日 週六 下午4:31寫道:
>
> if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have
> a corresponding put_device(). Thus add put_device() to fix the exception
> handling for this function implementation.
>

Reviewed-by: Chun-Kuang Hu <chunkuang.hu at kernel.org>

> Fixes: d0afe37f5209 ("drm/mediatek: support CMDQ interface in ddp component")
> Signed-off-by: Yu Kuai <yukuai3 at huawei.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> index 57c88de9a329..526648885b97 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> @@ -496,6 +496,7 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
>  #if IS_REACHABLE(CONFIG_MTK_CMDQ)
>         if (of_address_to_resource(node, 0, &res) != 0) {
>                 dev_err(dev, "Missing reg in %s node\n", node->full_name);
> +               put_device(&larb_pdev->dev);
>                 return -EINVAL;
>         }
>         comp->regs_pa = res.start;
> --
> 2.25.4
>



More information about the linux-arm-kernel mailing list