[PATCH v3 4/5] arm64: dts: ti: Add support for J7200 SoC
Nishanth Menon
nm at ti.com
Fri Sep 11 09:34:26 EDT 2020
On 21:47-20200910, Suman Anna wrote:
> On 9/10/20 1:20 PM, Nishanth Menon wrote:
> > On 12:54-20200910, Suman Anna wrote:
> > [...]
> >
> >>>> + };
> >>>
> >>> I think we could introduce base infrastructure stuff like intr and
> >>> inta nodes here? Also, the gpio_intr?
> >>
> >> FYI, they are currently being added in Patch 1 from Grygorii's "[v2,0/4] arm64:
> >> dts: ti: k3-j7200: add dma and mcu cpsw" series,
> >> https://patchwork.kernel.org/cover/11763711/
> >>
> >> The overall series seems to have some dependencies, so better to separate out
> >> those nodes and include as an additional add-on patch to this series, atleast it
> >> can unblock all others who use the TI-SCI Interrupt node.
> >>
> >
> > There is dependency on udma which in turn needs chipid stuff merged,
> > but I dont see anything preventing inta intr (which are infrastructure
> > components) from being merged in. It is not just udma driver that uses these
> > infrastructure.
>
> Yep, I also meant the same.
ok. Please squash the ia/intr in to this patch as well.
>
> >
> > [...]
> >>>> +
> >>>> +/ {
> >>>> + model = "Texas Instruments K3 J7200 SoC";
> >>>> + compatible = "ti,j7200";
> >>>> + interrupt-parent = <&gic500>;
> >>>> + #address-cells = <2>;
> >>>> + #size-cells = <2>;
[...]
> >>>> + serial11 = &main_uart9;
> >>>> + };
> >>>> +
> >>>
> >>> might be nice to leave a chosen { }; here to indicate board
> >>> files fill it up.. just to maintain consistency with rest of SoC dtsis?
> >>
> >> Doesn't serve any purpose IMO. I remember commenting about that blank node to
> >> remove it during some earlier reviews.
> >
[...]
>
> Yeah ok to add back then.
Lets squash the change to this patch.
Looking forward to the v4.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
More information about the linux-arm-kernel
mailing list