[Linux-stm32] [PATCH] ARM: dts: stm32: Consistently enable internal pull-ups for SD bus

[Marek Vasut]

On 10/15/20 3:18 PM, Ahmad Fatoum wrote:
> Hello Marek,

Hi,

> On 10/15/20 2:52 PM, Marek Vasut wrote:
>> On 10/15/20 2:44 PM, Ahmad Fatoum wrote:
>>
>> Hi,
>>
>> [...]
>>
>>> We already have 47K external pull-ups on all the SDMMC2's data lanes and we
>>> don't need the SoC-internal pull-up there as well.
>>>
>>> On the SDMMC1 we lack them, so they were added in the board DTS:
>>
>> You do need pullups on SD bus by default.
> 
> Yes, we are aware of this now :-)
> 
>> Currently the
>> stm32mp15-pinmux.dtsi is not consistent in that aspect. I am not arguing
>> about any one single board, but about the dtsi, I suspect by default the
>> pull ups should be enabled, and possibly on board-DT-level they should
>> be disabled if not needed instead ?
> 
> I think this is a good idea. But existing boards should be fixed up so that
> their old behavior is maintained.

So, which boards do we fix. The automation-1 board and the ST ones ?