[PATCH v2] gpio: mvebu: fix potential user-after-free on probe

[Uwe Kleine-König]

On Mon, Nov 30, 2020 at 05:09:53PM +0200, Baruch Siach wrote:
> When mvebu_pwm_probe() fails IRQ domain is not released. Goto the
> err_domain label on failure to release IRQ domain.
> 
> Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
> Reported-by: Andrew Lunn <andrew at lunn.ch>
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> ---
> v2: Don't leak pwm resources (Uwe Kleine-König)
> 
> This is split out of the "gpio: mvebu: Armada 8K/7K PWM support" series.
> I'll rebase the series v2 on top on this fix.
> ---
>  drivers/gpio/gpio-mvebu.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index 433e2c3f3fd5..c53ed975a180 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -1255,8 +1255,11 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Some MVEBU SoCs have simple PWM support for GPIO lines */
> -	if (IS_ENABLED(CONFIG_PWM))
> -		return mvebu_pwm_probe(pdev, mvchip, id);
> +	if (IS_ENABLED(CONFIG_PWM)) {
> +		err = mvebu_pwm_probe(pdev, mvchip, id);
> +		if (err)
> +			goto err_domain;

I only looked quickly, but I wonder if you need to undo
irq_alloc_domain_generic_chips(), too?!

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201130/f8cec7f5/attachment.sig>