[PATCH] bus: sunxi-rsb: make remove callback return void

[Uwe Kleine-König]

On Thu, Nov 26, 2020 at 08:03:16AM +0000, Lee Jones wrote:
> On Thu, 26 Nov 2020, Chen-Yu Tsai wrote:
> 
> > On Thu, Nov 26, 2020 at 3:41 PM Uwe Kleine-König
> > <u.kleine-koenig at pengutronix.de> wrote:
> > >
> > > The driver core ignores the return value of struct device_driver::remove
> > > because there is only little that can be done. To simplify the quest to
> > > make this function return void, let struct sunxi_rsb_driver::remove
> > > return void, too. All users already unconditionally return 0, this
> > > commit makes this obvious and ensures future users don't behave
> > > differently. To simplify even further, make axp20x_device_remove()
> > > return void instead of returning 0 unconditionally, too.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > 
> > Looks good to me.
> > 
> > Reviewed-by: Chen-Yu Tsai <wens at csie.org>
> > 
> > Since this touches the mfd tree as well, we either need an Ack from Lee,
> > the mfd maintainer (CC-ed), or let Lee take it in his tree. For the latter,
> 
> Right.  Thank you Chen-Yu.
> 
> Uwe, did you run get_maintainer.pl?

I thought I did, but obviously I somehow failed. (I have an idea what
went wrong, but I spare you the details.)

> Please re-submit this with the proper people on Cc.

sure, sorry for my confusion. 

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201126/c2657c7b/attachment.sig>