[PATCH 1/1] clk: imx: scu: fix MXC_CLK_SCU module build break
Aisheng Dong
aisheng.dong at nxp.com
Wed Nov 25 06:10:47 EST 2020
Hi Shawn, Stephen,
> From: Aisheng Dong <aisheng.dong at nxp.com>
> Sent: Wednesday, November 25, 2020 6:51 PM
>
> This issue can be reproduced by CONFIG_IMX_MBOX=m and
> CONFIG_MXC_CLK_SCU=m.
> It's caused by current Makefile can't support build clk-scu.o and clk-imx8qxp.o
> separately.
> "obj-$(CONFIG_MXC_CLK_SCU) += clk-imx-scu.o clk-imx-lpcg-scu.o
> clk-imx-scu-$(CONFIG_CLK_IMX8QXP) += clk-scu.o clk-imx8qxp.o"
> Only enable MXC_CLK_SCU while CLK_IMX8QXP not is meaningless and buggy.
>
> This patch makes MXC_CLK_SCU to be invisible to users and can only be selected
> by CLK_IMX8QXP option to ensure they're built together.
>
> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver
> as module")
> Reported-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> Signed-off-by: Dong Aisheng <aisheng.dong at nxp.com>
This patch is required for v5.10 rc5.
Please help review.
Regards
Aisheng
> ---
> drivers/clk/imx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> 3b393cb07295..dbacdd70af2e 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -5,7 +5,7 @@ config MXC_CLK
> depends on ARCH_MXC || COMPILE_TEST
>
> config MXC_CLK_SCU
> - tristate "IMX SCU clock"
> + tristate
> depends on ARCH_MXC || COMPILE_TEST
> depends on IMX_SCU && HAVE_ARM_SMCCC
>
> --
> 2.23.0
More information about the linux-arm-kernel
mailing list