Re:Re: [PATCH 0/2] drivers/tty: delete break after return or goto

Bernard bernard at vivo.com
Wed Nov 4 06:17:56 EST 2020



From: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Date: 2020-11-04 19:02:53
To:  Bernard Zhao <bernard at vivo.com>
Cc:  Jiri Slaby <jirislaby at kernel.org>,Shawn Guo <shawnguo at kernel.org>,Sascha Hauer <s.hauer at pengutronix.de>,Pengutronix Kernel Team <kernel at pengutronix.de>,Fabio Estevam <festevam at gmail.com>,NXP Linux Team <linux-imx at nxp.com>,linux-kernel at vger.kernel.org,linux-serial at vger.kernel.org,linux-arm-kernel at lists.infradead.org,opensource.kernel at vivo.com
Subject: Re: [PATCH 0/2] drivers/tty: delete break after return or goto>On Wed, Nov 04, 2020 at 02:53:29AM -0800, Bernard Zhao wrote:
>> This patch sereies optimise code like:
>> {
>> case XXX:
>> 	return XXX;
>> 	break; //The break is meanless, so just delete it.
>> case YYY:
>> 	goto YYY;
>> 	break; //The break is meanless, so just delete it.
>> ......
>> }
>> 
>> Signed-off-by: Bernard Zhao <bernard at vivo.com>
>> 
>> ---
>> Bernard Zhao (2):
>>   drivers/tty/nozomi.c: delete no use break after goto
>>   drivers/tty/serial/imx.c: delete no use break after return
>
>That is not the subject of the patches you sent out, what broke?

Hi:

I am sorry that I am a little confused:
The patch series`s subject is "drivers/tty: delete break after return or goto"
and the blurb is:
This patch sereies optimise code like:
{
case XXX:
	return XXX;
	break; //The break is meanless, so just delete it.
case YYY:
	goto YYY;
	break; //The break is meanless, so just delete it.
......
}
last, the modified files are:
Bernard Zhao (2):
  drivers/tty/nozomi.c: delete no use break after goto
  drivers/tty/serial/imx.c: delete no use break after return

Is there something wrong that I didn`t catch?

BR//Bernard




More information about the linux-arm-kernel mailing list