[PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

Lee Jones lee.jones at linaro.org
Tue Nov 3 03:18:05 EST 2020


On Tue, 03 Nov 2020, Uwe Kleine-König wrote:

> On Mon, Oct 26, 2020 at 09:33:00AM +0000, Lee Jones wrote:
> > On Thu, 22 Oct 2020, Uwe Kleine-König wrote:
> > 
> > > On Wed, Aug 12, 2020 at 09:11:39AM +0100, Lee Jones wrote:
> > > > On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> > > > 
> > > > > pwmchip_add() doesn't emit an error message, so add one in the driver.
> > > > 
> > > > Maybe placing one there would be a good idea.
> > > > 
> > > > It would certainly cut down on a lot of superfluous strings.
> > > 
> > > Hmm, I'm not convinced. Do you want to work on that? If not I suggest to
> > > still apply the patch as currently it is justified.
> > 
> > I haven't looked at implementing it.  Does it look difficult/
> 
> Probably it isn't, needs just some endurance to actually do it. (And I
> won't invest that in the near future, also because I'm not convinced
> that the result is beneficial.)

I'll add it to my TODO list.

In the mean time, don't let this halt the patch.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog



More information about the linux-arm-kernel mailing list