[PATCH] Revert "usb: dwc3: exynos: Add support for Exynos5422 suspend clk"

Krzysztof Kozlowski krzk at kernel.org
Tue Jun 23 05:20:15 EDT 2020


On Tue, 23 Jun 2020 at 09:46, Anand Moon <linux.amoon at gmail.com> wrote:
>
> This reverts commit 07f6842341abe978e6375078f84506ec3280ece5.
>
> Since SCLK_SCLK_USBD300 suspend clock need to be configured
> for phy module, I wrongly mapped this clock to DWC3 code.
>
> Cc: Felipe Balbi <balbi at kernel.org>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Signed-off-by: Anand Moon <linux.amoon at gmail.com>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 ---------
>  1 file changed, 9 deletions(-)

But why was this patch applied in the first place? It did not pass the
review. For the v3 I replied:
"This patchset should not be applied. As of now, it is not needed and
not justified."
There were no acks and no positive reviews.

My comments from previous versions of this patchset were not properly addressed.

So here - yes, makes sense to revert it as it should have never been applied.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list