[PATCH 05/14] drivers/firmware/sdei: Remove sdei_get_conduit()

James Morse james.morse at arm.com
Tue Jul 21 16:42:55 EDT 2020


Hi Gavin,

On 06/07/2020 06:47, Gavin Shan wrote:
> There are some logics in sdei_get_conduit() can be safely dropped:
> 
>    * There are no associated device node with the platform device,
>      so it's pointless to check on it.

This is for DT. Its looking up the conduit in the binding. See
Documentation/devicetree/bindings/arm/firmware/sdei.txt.


>    * ACPI functionality has been verified when the platform device
>      is added in sdei_init(). So it's unnecessary to recheck.

This is so that a kernel built without ACPI support can have all that code removed at
compile time. The check appears repeatedly to ensure the compiler knows this is dead code.


Thanks,

James



More information about the linux-arm-kernel mailing list