[PATCH V6 6/6] clk: imx6sl: Fix build warning reported by kernel test robot

Stephen Boyd sboyd at kernel.org
Wed Jul 15 21:00:17 EDT 2020


Quoting Anson Huang (2020-07-06 22:09:39)
> Use readl_relaxed() instead of __raw_readl(), and use BIT(x)
> instead of (1 << X) to fix below build warning reported by kernel
> test robot:
> 
> drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit
> value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
>      while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK))
> 
> Signed-off-by: Anson Huang <Anson.Huang at nxp.com>
> Reported-by: kernel test robot <lkp at intel.com>
> ---

The subject is poor. Please improve it so that it summarizes the change
instead of the reaction to a warning from a robot.

> New patch.
> ---
>  drivers/clk/imx/clk-imx6sl.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 

This should come earlier in the series too so that the build warning
doesn't come out before this patch is applied.



More information about the linux-arm-kernel mailing list