[PATCH 4/4] firmware: arm_scmi: Remove fixed size typing from event reports

Cristian Marussi cristian.marussi at arm.com
Wed Jul 8 08:22:48 EDT 2020


Event reports are used to convey information describing events to the
registered user-callbacks: they are necessarily derived from the underlying
raw SCMI events' messages but they are not meant to expose or directly
mirror any of those messages data layout, which belong to the protocol
layer.

Using fixed size fields mirroring messages structure is at odd with this:
get rid of them using more generic, equivalent, typing.

Signed-off-by: Cristian Marussi <cristian.marussi at arm.com>
---
 include/linux/scmi_protocol.h | 52 +++++++++++++++++------------------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h
index 7d4348fb7330..e51f392f464b 100644
--- a/include/linux/scmi_protocol.h
+++ b/include/linux/scmi_protocol.h
@@ -381,47 +381,47 @@ enum scmi_notification_events {
 };
 
 struct scmi_power_state_changed_report {
-	u64 timestamp;
-	u32 agent_id;
-	u32 domain_id;
-	u32 power_state;
+	unsigned long long	timestamp;
+	unsigned int		agent_id;
+	unsigned int		domain_id;
+	unsigned int		power_state;
 };
 
 struct scmi_perf_limits_report {
-	u64 timestamp;
-	u32 agent_id;
-	u32 domain_id;
-	u32 range_max;
-	u32 range_min;
+	unsigned long long	timestamp;
+	unsigned int		agent_id;
+	unsigned int		domain_id;
+	unsigned int		range_max;
+	unsigned int		range_min;
 };
 
 struct scmi_perf_level_report {
-	u64 timestamp;
-	u32 agent_id;
-	u32 domain_id;
-	u32 performance_level;
+	unsigned long long	timestamp;
+	unsigned int		agent_id;
+	unsigned int		domain_id;
+	unsigned int		performance_level;
 };
 
 struct scmi_sensor_trip_point_report {
-	u64 timestamp;
-	u32 agent_id;
-	u32 sensor_id;
-	u32 trip_point_desc;
+	unsigned long long	timestamp;
+	unsigned int		agent_id;
+	unsigned int		sensor_id;
+	unsigned int		trip_point_desc;
 };
 
 struct scmi_reset_issued_report {
-	u64 timestamp;
-	u32 agent_id;
-	u32 domain_id;
-	u32 reset_state;
+	unsigned long long	timestamp;
+	unsigned int		agent_id;
+	unsigned int		domain_id;
+	unsigned int		reset_state;
 };
 
 struct scmi_base_error_report {
-	u64 timestamp;
-	u32 agent_id;
-	bool fatal;
-	u16 cmd_count;
-	u64 reports[];
+	unsigned long long	timestamp;
+	unsigned int		agent_id;
+	bool			fatal;
+	unsigned int		cmd_count;
+	unsigned long long	reports[];
 };
 
 #endif /* _LINUX_SCMI_PROTOCOL_H */
-- 
2.17.1




More information about the linux-arm-kernel mailing list