[PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'

[Lee Jones]

On Mon, 06 Jul 2020, Eric W. Biederman wrote:

> Lee Jones <lee.jones at linaro.org> writes:
> 
> > 'ret' hasn't  been checked since the driver's inception in 2009.
> 
> Minor quibble the inception was in 5c05917e7fe3 ("x86: usb debug port
> early console, v4") in July of 2008.

I'm only going back as far as the inception of ehci-dbgp.c.

> Acked-by: "Eric W. Biederman" <ebiederm at xmission.com>

Great, thanks.

> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
> >  drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> >  915 | int chunk, ret;
> >  | ^~~
> >
> > Cc: Sumit Garg <sumit.garg at linaro.org>
> > Cc: Daniel Thompson <daniel.thompson at linaro.org>
> > Cc: Douglas Anderson <dianders at chromium.org>
> > Cc: Petr Mladek <pmladek at suse.com>
> > Cc: "Eric W. Biederman" <ebiederm at xmission.com>
> > Cc: Yinghai Lu <yhlu.kernel at gmail.com>
> > Cc: Jason Wessel <jason.wessel at windriver.com>
> > Signed-off-by: Lee Jones <lee.jones at linaro.org>
> > ---
> >  drivers/usb/early/ehci-dbgp.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog