[PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak
Markus Elfring
Markus.Elfring at web.de
Wed Jul 1 05:42:47 EDT 2020
> In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
> was not released in the error case. Thus add jump target for the completion
> of the desired exception handling.
Another small wording adjustment:
… Thus add a jump target …
…
> +++ b/drivers/irqchip/irq-xilinx-intc.c
…
> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
>
> return 0;
>
> +error_domain_remove:
> + irq_domain_remove(irqc->root_domain);
> error:
> iounmap(irqc->base);
…
Can labels like “remove_irq_domain” and “unmap_io” be nicer?
Regards,
Markus
More information about the linux-arm-kernel
mailing list