[RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe

Zheng Zengkai zhengzengkai at huawei.com
Tue Dec 22 21:13:03 EST 2020


Hi everyone,

Friendly ping:

Just want to know why this patch was ignored,

Am I missing something?

Merry Christmas and Happy New Year!

> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
> on one error handling path. This patch fixes that.
>
> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai at huawei.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> ---
>   drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index 417e05381b5d..bdf1f98dfad8 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -754,7 +754,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
>   
>   	ret = priv->drvdata->setup_regmaps(priv, base);
>   	if (ret)
> -		return ret;
> +		goto err_disable_clks;
>   
>   	if (priv->vbus) {
>   		ret = regulator_enable(priv->vbus);



More information about the linux-arm-kernel mailing list