[net-next PATCH v2 09/14] net/fsl: Use fwnode_mdiobus_register()

Calvin Johnson calvin.johnson at oss.nxp.com
Fri Dec 18 00:48:10 EST 2020


On Tue, Dec 15, 2020 at 07:55:01PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson
> <calvin.johnson at oss.nxp.com> wrote:
> >
> > fwnode_mdiobus_register() internally takes care of both DT
> > and ACPI cases to register mdiobus. Replace existing
> > of_mdiobus_register() with fwnode_mdiobus_register().
> >
> > Note: For both ACPI and DT cases, endianness of MDIO controller
> > need to be specified using "little-endian" property.
> 
> ...
> 
> > @@ -2,6 +2,7 @@
> >   * QorIQ 10G MDIO Controller
> >   *
> >   * Copyright 2012 Freescale Semiconductor, Inc.
> > + * Copyright 2020 NXP
> >   *
> >   * Authors: Andy Fleming <afleming at freescale.com>
> >   *          Timur Tabi <timur at freescale.com>
> > @@ -11,6 +12,7 @@
> 
> I guess this...
> 
> >         priv->is_little_endian = device_property_read_bool(&pdev->dev,
> >                                                            "little-endian");
> > -
> >         priv->has_a011043 = device_property_read_bool(&pdev->dev,
> >                                                       "fsl,erratum-a011043");
> 
> ...this...
> 
> > -
> 
> ...and this changes can go to a separate patch.

I think I'll remove the unnecessary cleanup.

Regards
Calvin




More information about the linux-arm-kernel mailing list