[PATCH] clk: versatile: Add of_node_put() before return statement
Linus Walleij
linus.walleij at linaro.org
Sun Aug 30 06:07:17 EDT 2020
On Sat, Aug 29, 2020 at 7:57 PM Sumera Priyadarsini
<sylphrenadin at gmail.com> wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>
> Fix a potential memory leak in clk-impd1.c by inserting
> of_node_put() before a return statement.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin at gmail.com>
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list