[PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration

Stephen Boyd sboyd at kernel.org
Wed Aug 12 03:59:34 EDT 2020


Quoting Krzysztof Kozlowski (2020-08-04 12:26:54)
> The s3c_camif_gpio_put() declaration in
> include/media/drv-intf/s3c_camif.h header was different than definition.
> Fixing this allows to include that header to also fix the W=1 compile
> warnings:
> 
>     arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous prototype for 's3c_camif_gpio_get' [-Wmissing-prototypes]
>        28 | int s3c_camif_gpio_get(void)
>     arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous prototype for 's3c_camif_gpio_put' [-Wmissing-prototypes]
>        56 | void s3c_camif_gpio_put(void)

Maybe it should have been void all along?



More information about the linux-arm-kernel mailing list