[PATCH] ARM: dts: stm32: Fill GPIO line names on AV96

[Marek Vasut]

On 8/6/20 9:09 AM, Christoph Niedermaier wrote:
> From: Marek Vasut <marex at denx.de>
> Sent: Friday, July 24, 2020 12:16 PM
>>
>> Fill in the custom GPIO line names used by DH.
>>
> [...]
>> +&gpioa {
>> +       gpio-line-names = "", "", "", "",
>> +                         "", "", "", "",
>> +                         "", "", "", "DH-GPIO-K",
>> +                         "DH-GPIO-I", "", "DH-GPIO-A", "";
>> +};
>> +
> [...]
> 
> Hello Marek,

Hello Christoph,

> We have been using the GPIO names at DH electronics for some time and also
> on other SOMs, but have not yet streamed them. We started with the naming
> only with a capital letter "A-W" since then without problems. To avoid a
> hard cut or patching for us and our customers it would be good if we could
> use the same naming in the mainline kernel as well. Marek, we would be
> happy if you would adopt our valued GPIO naming in your patch.

My counter-argument to this is that the naming should be unique and
provide a hint where those GPIO lines come from, so maybe even DH-GPIO-n
should rather be DHCOM-n . I can't say I'm particularly fond of the
plain 'n' naming of GPIO lines, because then the GPIO label (and e.g.
listing in libgpiod tools) does not give any hint what the GPIO is or
where it comes from. Also, I worry a plain 'n' naming might clash with
other GPIO IPs easily, while a more unique name can not.