[PATCH] iommu/io-pgtable-arm: Avoid warning with 32-bit phys_addr_t

Joerg Roedel joro at 8bytes.org
Thu Mar 29 06:22:30 PDT 2018


On Thu, Mar 29, 2018 at 12:24:52PM +0100, Robin Murphy wrote:
> It's not entirely unreasonable for io-pgtable-arm to be built for
> configurations with 32-bit phys_addr_t, where the compiler rightly
> raises a warning about the 36-bit shift. That particular code path
> should never actually *run* on those systems, but we still want it
> to compile cleanly, which is easily done by using an unambiguous u64
> as the intermediate type instead.
> 
> Signed-off-by: Robin Murphy <robin.murphy at arm.com>
> ---
> 
> Oops, I managed to totally overlook that phys_addr_t would be
> configuration-dependent, sorry :(
> 
> If this can't sneak in on top of the SMMU pull, I'll resend it 
> as a fix for -rc1. It shouldn't be super-critical.
> 
>  drivers/iommu/io-pgtable-arm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied it, thanks Robin.



More information about the linux-arm-kernel mailing list