[PATCH v2 2/4] arm64: dts: renesas: r8a7795: sort subnodes of the soc node

Geert Uytterhoeven geert at linux-m68k.org
Fri Mar 23 01:41:29 PDT 2018


Hi Simon,

On Thu, Mar 22, 2018 at 11:24 AM, Simon Horman
<horms+renesas at verge.net.au> wrote:
> Sort subnodes of the soc node.
> - The primary key is the bus address.
> - The secondary key is the IP block.
> - The tertiary key is the node name.
>
> This is part of an ongoing effort to provide consistent node
> order in the DT of Renesas SoCs to improve maintainability.
>
> This should not have any run-time effect.
>
> Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> ---
> v2
> * Rebase

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
using dtx_diff, and "grep '@.*{', which tells me

> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi

>                 pciec0: pcie at fe000000 {
> @@ -2097,6 +2090,23 @@
>                         status = "disabled";
>                 };
>
> +               gic: interrupt-controller at f1010000 {

Probably gic should be before pciec0.
Currently it's after pciec1, which has a lower address than pciec1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list